From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752413AbdHNDLQ (ORCPT ); Sun, 13 Aug 2017 23:11:16 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:50458 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431AbdHNDLP (ORCPT ); Sun, 13 Aug 2017 23:11:15 -0400 Date: Sun, 13 Aug 2017 20:11:13 -0700 (PDT) Message-Id: <20170813.201113.1487220436668237112.davem@davemloft.net> To: colin.king@canonical.com Cc: sainath.grandhi@intel.com, jasowang@redhat.com, rolf.neugebauer@docker.com, willemb@google.com, zhangshengju@cmss.chinamobile.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tap: make struct tap_fops static From: David Miller In-Reply-To: <20170812215231.6272-1-colin.king@canonical.com> References: <20170812215231.6272-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 13 Aug 2017 20:11:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Sat, 12 Aug 2017 22:52:31 +0100 > From: Colin Ian King > > The structure tap_fops is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'tap_fops' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Applied.