From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbdHNH2A (ORCPT ); Mon, 14 Aug 2017 03:28:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55048 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548AbdHNH17 (ORCPT ); Mon, 14 Aug 2017 03:27:59 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9B41BA0A56 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com From: Hans de Goede To: vbox-dev@virtualbox.org Cc: Michael Thayer , "Knut St . Osmundsen" , Arnd Bergmann , Greg Kroah-Hartman , Linux Kernel Mailing List Subject: [RFC] VGDrvCommonIoCtl: Add f32bit flag argument Date: Mon, 14 Aug 2017 09:27:55 +0200 Message-Id: <20170814072756.4729-1-hdegoede@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 14 Aug 2017 07:27:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Note to linux-kernel readers: This Cc-ed to linux-kernel because it is relevant for the "[RFC 0/2] Add Virtual Box vboxguest and vboxsf guest drivers to the mainline kernel" thread. Hi Michael, Knut, My first submission of the vboxguest driver for inclusion into the Linux kernel has lead to some questions about the use of the VBOXGUEST_IOCTL_FLAG to differentiate between 32 and 64 bit ioctls. Under Linux this is not necessary, as the driver already knows if it is serving a 32 bit compat or a regular ioctl. So I've come up with this patch to make VBOXGUEST_IOCTL_FLAG always 0 under Linux. I was hoping the f32bit flag could be used under more platforms so that it would actually be a cleanup, but it seems that Linux is the only platform with a compat_ioctl callback in its file-operations struct. Please let me know if you would be willing to merge this patch into upstream VirtualBox. Regards, Hans