mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleksandr Natalenko <oleksandr@redhat.com>
To: linux-block@vger.kernel.org
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: [RFC] block: deprecate choosing elevator via boot param
Date: Mon, 14 Aug 2017 11:27:12 +0200	[thread overview]
Message-ID: <20170814092712.14062-1-oleksandr@redhat.com> (raw)

Setting I/O scheduler via kernel command line is not flexible enough
anymore. Different schedulers might be desirable for different types
of devices (SSDs and HDDs, for instance). Moreover, setting elevator
while using blk-mq framework does not work in this way already.

This commit enables warning if user specifies "elevator" boot param.
Removing this option at all might be considered in some future.

Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
---
 block/elevator.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/elevator.c b/block/elevator.c
index 4bb2f0c93fa6..9ade7e12e417 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -130,6 +130,9 @@ static int __init elevator_setup(char *str)
 	 * Be backwards-compatible with previous kernels, so users
 	 * won't get the wrong elevator.
 	 */
+	printk(KERN_WARNING
+		"Setting I/O scheduler via kernel command line " \
+		"is deprecated. Use udev rule instead.");
 	strncpy(chosen_elevator, str, sizeof(chosen_elevator) - 1);
 	return 1;
 }
-- 
2.14.1

             reply	other threads:[~2017-08-14  9:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14  9:27 Oleksandr Natalenko [this message]
2017-08-30  6:18 ` Oleksandr Natalenko
2017-08-30 14:24 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814092712.14062-1-oleksandr@redhat.com \
    --to=oleksandr@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome