From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753074AbdHNLev (ORCPT ); Mon, 14 Aug 2017 07:34:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:55094 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753015AbdHNLes (ORCPT ); Mon, 14 Aug 2017 07:34:48 -0400 Date: Mon, 14 Aug 2017 13:34:45 +0200 From: Michal Hocko To: Pasha Tatashin Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com, heiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, ard.biesheuvel@linaro.org, will.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org, Mel Gorman Subject: Re: [v6 04/15] mm: discard memblock data later Message-ID: <20170814113445.GE19063@dhcp22.suse.cz> References: <1502138329-123460-1-git-send-email-pasha.tatashin@oracle.com> <1502138329-123460-5-git-send-email-pasha.tatashin@oracle.com> <20170811093249.GE30811@dhcp22.suse.cz> <42a04441-47ad-2fa0-ca3c-784c717213f7@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42a04441-47ad-2fa0-ca3c-784c717213f7@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 11-08-17 15:00:47, Pasha Tatashin wrote: > Hi Michal, > > This suggestion won't work, because there are arches without memblock > support: tile, sh... > > So, I would still need to have: > > #ifdef CONFIG_MEMBLOCK in page_alloc, or define memblock_discard() stubs in > nobootmem headfile. This is the standard way to do this. And it is usually preferred to proliferate ifdefs in the code. -- Michal Hocko SUSE Labs