From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Dmitry Safonov <dsafonov@virtuozzo.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>,
Cyrill Gorcunov <gorcunov@openvz.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: fix norandmaps
Date: Mon, 14 Aug 2017 19:24:57 +0300 [thread overview]
Message-ID: <20170814162457.w7ddsrmco73cfbai@node.shutemov.name> (raw)
In-Reply-To: <20170710111429.GA20038@redhat.com>
On Mon, Jul 10, 2017 at 01:14:29PM +0200, Oleg Nesterov wrote:
> Documentation/admin-guide/kernel-parameters.txt says:
>
> norandmaps Don't use address space randomization. Equivalent
> to echo 0 > /proc/sys/kernel/randomize_va_space
>
> but it doesn't work because arch_rnd() which is used to randomize
> mm->mmap_base returns a random value unconditionally.
>
> Shift the PF_RANDOMIZE check from arch_mmap_rnd() to arch_rnd().
>
> Fixes: 1b028f784e8c ("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()")
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
It also fixes personality(ADDR_NO_RANDOMIZE).
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2017-08-14 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 11:14 Oleg Nesterov
2017-07-10 11:14 ` [PATCH 2/2] x86/elf: remove the unnecessary ADDR_NO_RANDOMIZE checks in stack_maxrandom_size() and randomize_stack_top() Oleg Nesterov
2017-07-10 11:58 ` Dmitry Safonov
2017-07-10 11:56 ` [PATCH 1/2] x86: fix norandmaps Dmitry Safonov
2017-07-20 16:42 ` Oleg Nesterov
2017-08-14 16:24 ` Kirill A. Shutemov [this message]
2017-08-14 16:43 ` Oleg Nesterov
2017-08-14 16:44 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814162457.w7ddsrmco73cfbai@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=bp@suse.de \
--cc=dsafonov@virtuozzo.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome