From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753492AbdHODAv (ORCPT ); Mon, 14 Aug 2017 23:00:51 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34651 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753208AbdHODAt (ORCPT ); Mon, 14 Aug 2017 23:00:49 -0400 From: Sergey Senozhatsky To: Petr Mladek , Steven Rostedt Cc: Jan Kara , Andrew Morton , Peter Zijlstra , "Rafael J . Wysocki" , Eric Biederman , Greg Kroah-Hartman , Jiri Slaby , Pavel Machek , Andreas Mohr , Tetsuo Handa , linux-kernel@vger.kernel.org, Sergey Senozhatsky , Sergey Senozhatsky Subject: [RFC][PATCHv5 11/13] printk: always offload printing from user-space processes Date: Tue, 15 Aug 2017 11:56:23 +0900 Message-Id: <20170815025625.1977-12-sergey.senozhatsky@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170815025625.1977-1-sergey.senozhatsky@gmail.com> References: <20170815025625.1977-1-sergey.senozhatsky@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org console_lock() and, thus, console_unlock() can be executed by user-space processes doing sys calls (e.g. tty, drm, etc.) so we may end up in a situation when systemd loops in console_unlock() printing kernel messages. Always offload printing duty from user-space process (if we can safely wake up printk_kthread, of course). Signed-off-by: Sergey Senozhatsky --- kernel/printk/printk.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 6da4e21c3b45..0ffbaa33280f 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -592,6 +592,13 @@ static inline bool console_offload_printing(void) if (!is_printk_offloading_safe()) return false; + /* + * Always offload from user-space processes, we've got printk kthread + * for printing. + */ + if (!(current->flags & PF_KTHREAD)) + goto offload; + /* A new task - reset the counters. */ if (printing_task != current) { printing_start_ts = local_clock() >> 30LL; @@ -634,6 +641,7 @@ static inline bool console_offload_printing(void) return true; } +offload: /* * We try to set `printk_kthread' CPU affinity to any online CPU * except for this_cpu. Because otherwise `printk_kthread' may be -- 2.14.1