From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753344AbdHOHN4 (ORCPT ); Tue, 15 Aug 2017 03:13:56 -0400 Received: from mga05.intel.com ([192.55.52.43]:48060 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753097AbdHOHNz (ORCPT ); Tue, 15 Aug 2017 03:13:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,376,1498546800"; d="scan'208";a="1162694985" Date: Tue, 15 Aug 2017 10:11:44 +0300 From: Mika Westerberg To: "Bernat, Yehezkel" Cc: Greg Kroah-Hartman , Andreas Noever , Michael Jamet , Lukas Wunner , Andy Shevchenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] thunderbolt: Allow clearing the key Message-ID: <20170815071144.GI2369@lahna.fi.intel.com> References: <469e776b-331e-7b79-4f7d-2bd313449947@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <469e776b-331e-7b79-4f7d-2bd313449947@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 15, 2017 at 08:19:20AM +0300, Bernat, Yehezkel wrote: > If secure authentication of a devices fails, either because the device > already has another key uploaded, or there is some other error sending > challenge to the device, and the user only wants to approve the device > just once (without a new key being uploaded to the device) the current > implementation does not allow this because the key cannot be cleared > once set even if we allow it to be changed. > > Make this scenario possible and allow clearing the key by writing > empty string to the key sysfs file. > > Signed-off-by: Yehezkel Bernat Acked-by: Mika Westerberg