From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608AbdHOO4Z (ORCPT ); Tue, 15 Aug 2017 10:56:25 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:33329 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbdHOO4X (ORCPT ); Tue, 15 Aug 2017 10:56:23 -0400 Date: Tue, 15 Aug 2017 07:56:21 -0700 From: Guenter Roeck To: Arnd Bergmann Cc: Jean Delvare , Jaghathiswari Rankappagounder Natarajan , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: aspeed: add THERMAL dependency Message-ID: <20170815145621.GA18049@roeck-us.net> References: <20170815144856.2059759-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170815144856.2059759-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 15, 2017 at 04:47:47PM +0200, Arnd Bergmann wrote: > With CONFIG_THERMAL=m, a built-in aspeed pwm tacho driver causes > a link error: > > drivers/hwmon/aspeed-pwm-tacho.o: In function `aspeed_pwm_tacho_probe': > aspeed-pwm-tacho.c:(.text+0x7f0): undefined reference to `thermal_of_cooling_device_register' > > This adds a dependency similar to what other hwmon drivers use, > ensuring that the aspeed driver cannot be built-in in this > case but has to be a module. With THERMAL=n, we still allow building it. > > Fixes: 2d7a548a3eff ("drivers: hwmon: Support for ASPEED PWM/Fan tach") > Signed-off-by: Arnd Bergmann Applied to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index 5ef2814345ef..5b9a61f766ac 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -343,6 +343,7 @@ config SENSORS_ASB100 > > config SENSORS_ASPEED > tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver" > + depends on THERMAL || THERMAL=n > select REGMAP > help > This driver provides support for ASPEED AST2400/AST2500 PWM > -- > 2.9.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html