From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753165AbdHPAfY (ORCPT <rfc822;w@1wt.eu>);
        Tue, 15 Aug 2017 20:35:24 -0400
Received: from mail.kernel.org ([198.145.29.99]:46542 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752859AbdHPAfX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 15 Aug 2017 20:35:23 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C85522B4F
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Tue, 15 Aug 2017 20:35:19 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Nick Kralevich <nnk@google.com>,
        Sebastian Schmidt <yath@yath.de>, Tony Luck <tony.luck@intel.com>,
        Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>,
        Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Patrick Tjin <pattjin@google.com>, Mark Salyzyn <salyzyn@google.com>
Subject: Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on
 dmesg dumps"
Message-ID: <20170815203519.587fb1d7@gandalf.local.home>
In-Reply-To: <CAGXu5jLtJt1=t7242gU22yf39p-96G+DhLspKEcAgA3q5AFxvQ@mail.gmail.com>
References: <1502397395-118652-1-git-send-email-keescook@chromium.org>
        <1502397395-118652-3-git-send-email-keescook@chromium.org>
        <20170815202127.08216e94@gandalf.local.home>
        <CAGXu5jLtJt1=t7242gU22yf39p-96G+DhLspKEcAgA3q5AFxvQ@mail.gmail.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 15 Aug 2017 17:29:38 -0700
Kees Cook <keescook@chromium.org> wrote:

> On Tue, Aug 15, 2017 at 5:21 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Thu, 10 Aug 2017 13:36:35 -0700
> > Kees Cook <keescook@chromium.org> wrote:
> >  
> >> This reverts commit 68c4a4f8abc60c9440ede9cd123d48b78325f7a3, with
> >> various conflict clean-ups.
> >>
> >> With the default root directory mode set to 0750 now, the capability
> >> check was redundant.  
> >
> > What's wrong with redundancy?  
> 
> In this case, it actually _blocks_ system builders from being able to
> define the access controls on pstore. :(

Then that should be stated in the change log, as it is the real reason
to revert, not just the fact that it is redundant.

Thanks,

-- Steve