From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752417AbdHPSrX (ORCPT ); Wed, 16 Aug 2017 14:47:23 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35316 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbdHPSrW (ORCPT ); Wed, 16 Aug 2017 14:47:22 -0400 Date: Wed, 16 Aug 2017 11:47:21 -0700 (PDT) Message-Id: <20170816.114721.2286909258495579175.davem@davemloft.net> To: aviad.krawczyk@huawei.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bc.y@huawei.com, victor.gissin@huawei.com, zhaochen6@huawei.com, tony.qu@huawei.com Subject: Re: [PATCH V4 net-next 21/21] net-next/hinic: Add select_queue and netpoll From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 16 Aug 2017 11:47:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aviad Krawczyk Date: Wed, 16 Aug 2017 20:03:06 +0800 > +static u16 hinic_select_queue(struct net_device *netdev, struct sk_buff *skb, > + void *accel_priv, > + select_queue_fallback_t fallback) > +{ > + u16 qid; > + > + if (skb_rx_queue_recorded(skb)) > + qid = skb_get_rx_queue(skb); > + else > + qid = fallback(netdev, skb); > + > + return qid; > +} This is a NOP, do not implement this function unless you absolutely need to do something custom in your driver, and you do not.