From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528AbdHPV1y (ORCPT ); Wed, 16 Aug 2017 17:27:54 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38698 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330AbdHPV1x (ORCPT ); Wed, 16 Aug 2017 17:27:53 -0400 Date: Wed, 16 Aug 2017 14:27:52 -0700 (PDT) Message-Id: <20170816.142752.600537690273356198.davem@davemloft.net> To: jasowang@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, eric.dumazet@gmail.com Subject: Re: [PATCH] tun: make tun_build_skb() thread safe From: David Miller In-Reply-To: <1502892873-10770-1-git-send-email-jasowang@redhat.com> References: <1502892873-10770-1-git-send-email-jasowang@redhat.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 16 Aug 2017 14:27:52 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Wang Date: Wed, 16 Aug 2017 22:14:33 +0800 > From: Eric Dumazet > > tun_build_skb() is not thread safe since it uses per queue page frag, > this will break things when multiple threads are sending through same > queue. Switch to use per-thread generator (no lock involved). > > Fixes: 66ccbc9c87c2 ("tap: use build_skb() for small packet") > Tested-by: Jason Wang > Signed-off-by: Eric Dumazet > Signed-off-by: Jason Wang Applied, thanks.