From: Thomas Richter <tmricht@linux.vnet.ibm.com>
To: john.stultz@linaro.org, tglx@linutronix.de, linux-kernel@vger.kernel.org
Cc: brueckner@linux.vnet.ibm.com, heiko.carstens@de.ibm.com,
schwidefsky@de.ibm.com,
Thomas Richter <tmricht@linux.vnet.ibm.com>
Subject: [PATCH] tools: fix compile error of freq-step.c
Date: Wed, 16 Aug 2017 08:08:37 +0200 [thread overview]
Message-ID: <20170816060837.16612-1-tmricht@linux.vnet.ibm.com> (raw)
The compilation of the file freq-step.c in directory
tools/testing/selftests/timers fails with this error message:
[root@s8360046 timers]# make
gcc -O3 -Wl,-no-as-needed -Wall -DKTEST -lrt -lpthread -lm freq-step.c
-o freq-step
freq-step.c: In function ‘init_test’:
freq-step.c:234:3: error: too few arguments to function ‘ksft_exit_skip’
ksft_exit_skip();
^~~~~~~~~~~~~~
In file included from freq-step.c:26:0:
../kselftest.h:142:19: note: declared here
static inline int ksft_exit_skip(const char *msg, ...)
^~~~~~~~~~~~~~
<builtin>: recipe for target 'freq-step' failed
make: *** [freq-step] Error 1
[root@s8360046 timers]#
This is the case for Intel and s390x. I have not tested other
platforms.
Which this patch the compilation succeeds:
[root@s8360046 timers]# make
gcc -O3 -Wl,-no-as-needed -Wall -DKTEST -lrt -lpthread -lm freq-step.c -o freq-step
[root@s8360046 timers]# ./freq-step
CLOCK_MONOTONIC_RAW+CLOCK_MONOTONIC precision: 348 ns [SKIP]
1..0 # Skipped: [SKIP]
[root@s8360046 timers]#
Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
---
tools/testing/selftests/timers/freq-step.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/timers/freq-step.c b/tools/testing/selftests/timers/freq-step.c
index e8c6183..bda9744 100644
--- a/tools/testing/selftests/timers/freq-step.c
+++ b/tools/testing/selftests/timers/freq-step.c
@@ -231,7 +231,7 @@ static void init_test(void)
if (precision > MAX_PRECISION) {
printf("[SKIP]\n");
- ksft_exit_skip();
+ ksft_exit_skip("[SKIP]\n");
}
printf("[OK]\n");
--
2.9.3
next reply other threads:[~2017-08-16 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 6:08 Thomas Richter [this message]
2017-08-16 18:27 ` John Stultz
2017-08-16 18:49 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816060837.16612-1-tmricht@linux.vnet.ibm.com \
--to=tmricht@linux.vnet.ibm.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®