From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rishabh Hardas <rishabhhardas@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, rjosephwright@gmail.com,
linux@Wolf-Entwicklungen.de, colin.king@canonical.com
Subject: Re: [PATCH v2 3/4] staging: pi433: Renaming Enums
Date: Wed, 16 Aug 2017 10:34:13 +0300 [thread overview]
Message-ID: <20170816073413.b2lll5daflcje2kl@mwanda> (raw)
In-Reply-To: <1bb3eea9cfefad627039c14b26de433d37bab51e.1501759442.git.rishabhhardas@gmail.com>
On Wed, Aug 16, 2017 at 10:53:20AM +0530, Rishabh Hardas wrote:
> Remove camel casing by renaming enums.
>
> Signed-off-by: Rishabh Hardas <rishabhhardas@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.h | 36 ++++++++++++++++--------------------
> drivers/staging/pi433/rf69.c | 26 +++++++++++++-------------
> drivers/staging/pi433/rf69.h | 26 +++++++++++++-------------
> drivers/staging/pi433/rf69_enum.h | 16 ++++++++--------
> 4 files changed, 50 insertions(+), 54 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
> index 84032f3..2929de0 100644
> --- a/drivers/staging/pi433/pi433_if.h
> +++ b/drivers/staging/pi433/pi433_if.h
> @@ -62,21 +62,20 @@ struct pi433_tx_cfg {
> __u16 bit_rate;
> __u32 dev_frequency;
> enum modulation modulation;
> - enum modShaping modShaping;
> + enum mod_shaping modShaping;
Now the names don't line up.
regards,
dan carpenter
next prev parent reply other threads:[~2017-08-16 7:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 11:50 [PATCH v2 0/4] staging: pi433: Rename camel case and other style issues Rishabh Hardas
2017-08-03 11:50 ` [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines Rishabh Hardas
2017-08-15 0:42 ` Greg KH
2017-08-16 7:31 ` Dan Carpenter
2017-08-20 4:47 ` Joe Perches
2017-08-22 9:27 ` Rishabh Hardas
2017-08-22 10:03 ` Dan Carpenter
2017-08-22 10:29 ` Marcus Wolf
2017-08-22 10:43 ` Dan Carpenter
2017-08-03 11:50 ` [PATCH v2 2/4] staging: pi433: Change Comments Rishabh Hardas
2017-08-16 7:35 ` Dan Carpenter
2017-08-03 11:50 ` [PATCH v2 3/4] staging: pi433: Renaming Enums Rishabh Hardas
2017-08-16 7:34 ` Dan Carpenter [this message]
2017-08-03 11:50 ` [PATCH v2 4/4] staging: pi433: Remove camel case variable names Rishabh Hardas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816073413.b2lll5daflcje2kl@mwanda \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
--cc=rishabhhardas@gmail.com \
--cc=rjosephwright@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome