From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853AbdHPIyl (ORCPT ); Wed, 16 Aug 2017 04:54:41 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:18462 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbdHPIyj (ORCPT ); Wed, 16 Aug 2017 04:54:39 -0400 Date: Wed, 16 Aug 2017 11:54:17 +0300 From: Dan Carpenter To: Andreas Noever , Mika Westerberg , Greg KH Cc: Michael Jamet , Yehezkel Bernat , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Colin King Subject: [PATCH resend] thunderbolt: Fix reset response_type Message-ID: <20170816085417.7xlnl54jkx2p36qs@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <735914a9-3d8f-7d98-35c3-6e2e046e70c2@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET) instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the same as TB_CFG_PKG_NOTIFY_ACK. Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable") Reported-by: Colin King Signed-off-by: Dan Carpenter Acked-by: Mika Westerberg --- Resending with Greg CC'd. This was also: Signed-off-by: Andreas Noever But I wasn't sure if I should add that tag. diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c index 69c0232a22f8..fb40dd0588b9 100644 --- a/drivers/thunderbolt/ctl.c +++ b/drivers/thunderbolt/ctl.c @@ -804,7 +804,7 @@ struct tb_cfg_result tb_cfg_reset(struct tb_ctl *ctl, u64 route, req->request_type = TB_CFG_PKG_RESET; req->response = &reply; req->response_size = sizeof(reply); - req->response_type = sizeof(TB_CFG_PKG_RESET); + req->response_type = TB_CFG_PKG_RESET; res = tb_cfg_request_sync(ctl, req, timeout_msec);