From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751843AbdHPLMu (ORCPT ); Wed, 16 Aug 2017 07:12:50 -0400 Received: from mail-wr0-f179.google.com ([209.85.128.179]:35858 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbdHPLMr (ORCPT ); Wed, 16 Aug 2017 07:12:47 -0400 Date: Wed, 16 Aug 2017 14:12:44 +0300 From: "Kirill A. Shutemov" To: Dan Williams Cc: akpm@linux-foundation.org, Jan Kara , "Darrick J. Wong" , linux-api@vger.kernel.org, linux-nvdimm@lists.01.org, Dave Chinner , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, Jeff Moyer , Alexander Viro , luto@kernel.org, linux-fsdevel@vger.kernel.org, Ross Zwisler , Christoph Hellwig Subject: Re: [PATCH v5 4/5] fs, xfs: introduce MAP_DIRECT for creating block-map-atomic file ranges Message-ID: <20170816111244.uxx6kvbi3cn5clqd@node.shutemov.name> References: <150286944610.8837.9513410258028246174.stgit@dwillia2-desk3.amr.corp.intel.com> <150286946864.8837.17147962029964281564.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <150286946864.8837.17147962029964281564.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 16, 2017 at 12:44:28AM -0700, Dan Williams wrote: > @@ -1411,6 +1422,9 @@ unsigned long do_mmap(struct file *file, unsigned long addr, > > /* fall through */ > case MAP_PRIVATE: > + if ((flags & (MAP_PRIVATE|MAP_DIRECT)) > + == (MAP_PRIVATE|MAP_DIRECT)) > + return -EINVAL; We've already checked for MAP_PRIVATE in this codepath. Simple (flags & MAP_DIRECT) would be enough. -- Kirill A. Shutemov