From: Steven Rostedt <rostedt@goodmis.org>
To: Waiman Long <longman@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] blktrace: Fix potentail deadlock between delete & sysfs ops
Date: Wed, 16 Aug 2017 14:59:38 -0400 [thread overview]
Message-ID: <20170816145938.6cc7eaee@gandalf.local.home> (raw)
In-Reply-To: <4841e079-c518-cdff-2fbd-661a9ef36722@redhat.com>
On Wed, 16 Aug 2017 14:46:42 -0400
Waiman Long <longman@redhat.com> wrote:
> I haven't been thinking about RT tasks. You are right that it can be a
> problem in this case. I think I will have to revert back to use
> mutex_lock() if a RT task is running. Though in this case, the lock
> inversion problem will still be there. However, it is highly unlikely
> that a RT task will need to read write the block trace sysfs files.
And it is highly unlikely that the lock inversion will happen. But
let's not switch one bug with another. And with PREEMPT_RT coming, that
can boost tasks into being RT, it can make the likelihood of RT tasks
running normally non RT tasks higher.
-- Steve
next prev parent reply other threads:[~2017-08-16 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 17:02 Waiman Long
2017-08-15 23:11 ` Steven Rostedt
2017-08-16 18:14 ` Waiman Long
2017-08-16 18:17 ` Steven Rostedt
2017-08-16 18:46 ` Waiman Long
2017-08-16 18:59 ` Steven Rostedt [this message]
2017-08-16 19:07 ` Waiman Long
2017-08-16 19:14 ` Steven Rostedt
2017-08-16 19:26 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816145938.6cc7eaee@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=axboe@kernel.dk \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®