From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbdHPRQx (ORCPT ); Wed, 16 Aug 2017 13:16:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50096 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751844AbdHPRQw (ORCPT ); Wed, 16 Aug 2017 13:16:52 -0400 Date: Wed, 16 Aug 2017 10:16:48 -0700 From: Greg Kroah-Hartman To: Colin King Cc: Stuart Yoder , Laurentiu Tudor , Wei Yongjun , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "staging: fsl-mc: be consistent when checking strcmp() return" Message-ID: <20170816171647.GA27365@kroah.com> References: <20170816171200.31259-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170816171200.31259-1-colin.king@canonical.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 16, 2017 at 06:12:00PM +0100, Colin King wrote: > From: Colin Ian King > > The previous fix removed the equal to zero comparisons by the strcmps and > now the function always returns true. Revert this change to restore the > original correctly functioning code. > > Detected by CoverityScan, CID#1452267 ("Constant expression result") > > This reverts commit b93ad9a067e1515af42da7d56bc61f1a25075f94. So this should say: Fixes: XXXXXX right? And it should get into 4.13-final, right? Or if not, at least backported to 4.13-stable? Can you please resend it with the fixes tag? thanks, greg k-h