From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752510AbdHPSGx (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Aug 2017 14:06:53 -0400
Received: from mail-wr0-f193.google.com ([209.85.128.193]:34858 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752444AbdHPSGv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Aug 2017 14:06:51 -0400
Date: Wed, 16 Aug 2017 20:06:46 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] completion: Document that reinit_completion() must be
 called after complete_all()
Message-ID: <20170816180646.fmzud667ympfueln@gmail.com>
References: <20170816131202.195c2f4b@gandalf.local.home>
 <CA+55aFyit5DnE+ktAhJfCJXF-pAE2X8KdT+hf-e9+gM5RU=3ZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFyit5DnE+ktAhJfCJXF-pAE2X8KdT+hf-e9+gM5RU=3ZA@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Wed, Aug 16, 2017 at 10:12 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > The function complete_all() modifies the completion "done" variable to
> > UINT_MAX, and no other caller (wait_for_completion(), etc) will modify
> > it back to zero. That means that any call to complete_all() must have a
> > reinit_completion() before that completion can be used again.
> >
> > Document this fact by the complete_all() function.
> >
> > Also document that completion_done() will always return true if
> > complete_all() is called.
> 
> Ack. Do I take it directly or is it indended for some other tree?

Will add it to the scheduler tree.

Thanks,

	Ingo