From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
x86@kernel.org, lguest@lists.ozlabs.org,
boris.ostrovsky@oracle.com, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, rusty@rustcorp.com.au
Subject: Re: [PATCH v2 1/2] paravirt,xen: remove xen_patch()
Date: Wed, 16 Aug 2017 14:16:53 -0500 [thread overview]
Message-ID: <20170816191653.igbuzhmdrf2tqzrb@treble> (raw)
In-Reply-To: <20170816173157.8633-2-jgross@suse.com>
On Wed, Aug 16, 2017 at 07:31:56PM +0200, Juergen Gross wrote:
> ENTRY(xen_irq_disable_direct)
> movb $1, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_mask
> -ENDPATCH(xen_irq_disable_direct)
> ret
> ENDPROC(xen_irq_disable_direct)
> - RELOC(xen_irq_disable_direct, 0)
Might as well remove the ENDPROC indentations while you're at it, for
readability and consistency with other asm code.
Otherwise,
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
next prev parent reply other threads:[~2017-08-16 19:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 17:31 [PATCH v2 0/2] x86: paravirt related cleanup Juergen Gross
2017-08-16 17:31 ` [PATCH v2 1/2] paravirt,xen: remove xen_patch() Juergen Gross
2017-08-16 19:16 ` Josh Poimboeuf [this message]
2017-08-18 13:22 ` Boris Ostrovsky
2017-08-24 8:25 ` [tip:x86/asm] x86/paravirt/xen: Remove xen_patch() tip-bot for Juergen Gross
2017-08-16 17:31 ` [PATCH v2 2/2] x86/lguest: remove lguest support Juergen Gross
2017-08-24 8:25 ` [tip:x86/asm] x86/lguest: Remove " tip-bot for Juergen Gross
2017-08-17 0:58 ` [PATCH v2 0/2] x86: paravirt related cleanup Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816191653.igbuzhmdrf2tqzrb@treble \
--to=jpoimboe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=lguest@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®