From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750960AbdHRFDp (ORCPT ); Fri, 18 Aug 2017 01:03:45 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:44128 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbdHRFDo (ORCPT ); Fri, 18 Aug 2017 01:03:44 -0400 Date: Thu, 17 Aug 2017 22:03:43 -0700 (PDT) Message-Id: <20170817.220343.905568389038615738.davem@davemloft.net> To: stephen@networkplumber.org Cc: aviad.krawczyk@huawei.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bc.y@huawei.com, victor.gissin@huawei.com, zhaochen6@huawei.com, tony.qu@huawei.com Subject: Re: [PATCH V5 net-next 01/21] net-next/hinic: Initialize hw interface From: David Miller In-Reply-To: <20170817174205.6a1b12b6@xeon-e3> References: <544e2ccb65ea083d9b736df6ea0bdd59353da815.1502970631.git.aviad.krawczyk@huawei.com> <20170817174205.6a1b12b6@xeon-e3> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 17 Aug 2017 22:03:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Hemminger Date: Thu, 17 Aug 2017 17:42:05 -0700 > Please drop these functions, they do nothing and are not used > as stubs in any operations table. It might have been helpful to scan the entire series to understand why it looks this way. He's building the driver up, one piece at a time, filling in the full implementation as is possible as more and more infrastructure is added. So some functions start empty when a method is needed to be filled in, and then gradually obtains more and more content throughout the series. And this is a fine way to add a huge new driver (although not my personal preference).