From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751606AbdHRFEC (ORCPT ); Fri, 18 Aug 2017 01:04:02 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:44138 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbdHRFD7 (ORCPT ); Fri, 18 Aug 2017 01:03:59 -0400 Date: Thu, 17 Aug 2017 22:03:58 -0700 (PDT) Message-Id: <20170817.220358.1098888253167010337.davem@davemloft.net> To: stephen@networkplumber.org Cc: aviad.krawczyk@huawei.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bc.y@huawei.com, victor.gissin@huawei.com, zhaochen6@huawei.com, tony.qu@huawei.com Subject: Re: [PATCH V5 net-next 01/21] net-next/hinic: Initialize hw interface From: David Miller In-Reply-To: <20170817174540.46986450@xeon-e3> References: <544e2ccb65ea083d9b736df6ea0bdd59353da815.1502970631.git.aviad.krawczyk@huawei.com> <20170817174540.46986450@xeon-e3> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 17 Aug 2017 22:03:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Hemminger Date: Thu, 17 Aug 2017 17:45:40 -0700 > On Thu, 17 Aug 2017 19:52:42 +0800 > Aviad Krawczyk wrote: > >> + nic_dev = (struct hinic_dev *)netdev_priv(netdev); > > Since netdev_priv() returns void *, a cast is not necessary here. Agreed.