From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241AbdHQHtd (ORCPT ); Thu, 17 Aug 2017 03:49:33 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:38629 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbdHQHtc (ORCPT ); Thu, 17 Aug 2017 03:49:32 -0400 Date: Thu, 17 Aug 2017 09:49:29 +0200 From: Ingo Molnar To: Byungchul Park Cc: peterz@infradead.org, linux-kernel@vger.kernel.org, kernel-team@lge.com Subject: Re: [PATCH] lockdep: Make LOCKDEP_CROSSRELEASE part of PROVE_LOCKING Message-ID: <20170817074929.z5b3fisqs63qvcmc@gmail.com> References: <1502929648-24137-1-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502929648-24137-1-git-send-email-byungchul.park@lge.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Byungchul Park wrote: > I am not sure if I did as Ingo suggested. Is this what you intended? > > ----->8----- > From 64c705bfedf45b2c56a0d2f4c65a998a1b730310 Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Thu, 17 Aug 2017 09:12:18 +0900 > Subject: [PATCH] lockdep: Make LOCKDEP_CROSSRELEASE part of PROVE_LOCKING > > Crossrelease added the following two configs in Kconfig: > > LOCKDEP_CROSSRELEASE depending on PROVE_LOCKING > LOCKDEP_COMPLETE depending on PROVE_LOCKING > > Remove the dependencies and make them all part of PROVE_LOCKING, like > most of the other lock debugging bits. > > Signed-off-by: Byungchul Park > --- > lib/Kconfig.debug | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index ee9e534..43ab713 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1084,6 +1084,8 @@ config PROVE_LOCKING > select DEBUG_MUTEXES > select DEBUG_RT_MUTEXES if RT_MUTEXES > select DEBUG_LOCK_ALLOC > + select LOCKDEP_CROSSRELEASE > + select LOCKDEP_COMPLETE > select TRACE_IRQFLAGS > default n > help > @@ -1155,7 +1157,7 @@ config LOCK_STAT > > config LOCKDEP_CROSSRELEASE > bool "Lock debugging: make lockdep work for crosslocks" > - depends on PROVE_LOCKING > + depends on DEBUG_KERNEL This should be a non-interactive option - it makes little sense to enable it when lockdep is disabled. > default n > help > This makes lockdep work for crosslock which is a lock allowed to > @@ -1167,7 +1169,7 @@ config LOCKDEP_CROSSRELEASE > > config LOCKDEP_COMPLETE > bool "Lock debugging: allow completions to use deadlock detector" > - depends on PROVE_LOCKING > + depends on DEBUG_KERNEL > select LOCKDEP_CROSSRELEASE Ditto. Thanks, Ingo