From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751861AbdHQKpt (ORCPT ); Thu, 17 Aug 2017 06:45:49 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34094 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbdHQKps (ORCPT ); Thu, 17 Aug 2017 06:45:48 -0400 Date: Thu, 17 Aug 2017 12:45:44 +0200 From: Ingo Molnar To: torvalds@linux-foundation.org, peterz@infradead.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, byungchul.park@lge.com, hpa@zytor.com Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:locking/core] locking/lockdep: Make CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING Message-ID: <20170817104544.p5vvdx2zrvjgpflh@gmail.com> References: <1502960261-16206-1-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * tip-bot for Byungchul Park wrote: > Commit-ID: d0541b0fa64b36665d6261079974a26943c75009 > Gitweb: http://git.kernel.org/tip/d0541b0fa64b36665d6261079974a26943c75009 > Author: Byungchul Park > AuthorDate: Thu, 17 Aug 2017 17:57:39 +0900 > Committer: Ingo Molnar > CommitDate: Thu, 17 Aug 2017 11:38:54 +0200 > > locking/lockdep: Make CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING > > Crossrelease support added the CONFIG_LOCKDEP_CROSSRELEASE and CONFIG_LOCKDEP_COMPLETE > options. It makes little sense to enable them when PROVE_LOCKING is disabled. > > Make them non-interative options and part of PROVE_LOCKING to simplify the UI. > > Signed-off-by: Byungchul Park > Cc: Linus Torvalds > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: kernel-team@lge.com > Link: http://lkml.kernel.org/r/1502960261-16206-1-git-send-email-byungchul.park@lge.com > Signed-off-by: Ingo Molnar > --- > lib/Kconfig.debug | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index ebd40d3..1ad7f1b 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1081,6 +1081,8 @@ config PROVE_LOCKING > select DEBUG_MUTEXES > select DEBUG_RT_MUTEXES if RT_MUTEXES > select DEBUG_LOCK_ALLOC > + select LOCKDEP_CROSSRELEASE > + select LOCKDEP_COMPLETE > select TRACE_IRQFLAGS > default n > help > @@ -1152,8 +1154,6 @@ config LOCK_STAT > > config LOCKDEP_CROSSRELEASE > bool "Lock debugging: make lockdep work for crosslocks" > - depends on PROVE_LOCKING > - default n > help > This makes lockdep work for crosslock which is a lock allowed to > be released in a different context from the acquisition context. > @@ -1164,9 +1164,6 @@ config LOCKDEP_CROSSRELEASE > > config LOCKDEP_COMPLETE > bool "Lock debugging: allow completions to use deadlock detector" > - depends on PROVE_LOCKING > - select LOCKDEP_CROSSRELEASE > - default n > help Yeah, so I only noticed this after committing the patches, but this change does not make the option non-interactive. The way to do that is to remove the "" help text, i.e. make it a simple 'bool'. I'll do that and re-push. Thanks, Ingo