From: Borislav Petkov <bp@suse.de>
To: Dongjiu Geng <gengdongjiu@huawei.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: will.deacon@arm.com, zjzhang@codeaurora.org,
catalin.marinas@arm.com, tbaicar@codeaurora.org,
james.morse@arm.com, geliangtang@gmail.com,
andriy.shevchenko@linux.intel.com, tony.luck@intel.com,
austinwc@codeaurora.org, rjw@rjwysocki.net, lenb@kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, john.garry@huawei.com,
shiju.jose@huawei.com, zhengqiang10@huawei.com,
wangxiongfeng2@huawei.com, huangshaoyu@huawei.com,
wuquanming@huawei.com
Subject: Re: [PATCH v4] acpi: apei: fix the wrong iteration of generic error status block
Date: Thu, 17 Aug 2017 13:43:49 +0200 [thread overview]
Message-ID: <20170817114349.uxtossvvaccuwy5g@pd.tnic> (raw)
In-Reply-To: <1502971638-31670-1-git-send-email-gengdongjiu@huawei.com>
On Thu, Aug 17, 2017 at 08:07:18PM +0800, Dongjiu Geng wrote:
> The revision 0x300 generic error data entry is different
> from the old version, but currently iterating through the
> GHES estatus blocks does not take into account this difference.
> This will lead to failure to get the right data entry if GHES
> has revision 0x300 error data entry.
>
> Update the GHES estatus iteration to properly increment using
> iteration macro,
This is not what I meant - I meant:
"Update the GHES estatus iteration macro to properly increment using
acpi_hest_get_next(), and ..."
But you don't need to send another version.
Rafael, please correct that when applying, instead.
Thanks.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2017-08-17 11:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 12:07 Dongjiu Geng
2017-08-17 11:43 ` Borislav Petkov [this message]
2017-08-17 20:44 ` Rafael J. Wysocki
2017-08-28 20:57 ` Rafael J. Wysocki
2017-08-29 1:10 ` gengdongjiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817114349.uxtossvvaccuwy5g@pd.tnic \
--to=bp@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=austinwc@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=geliangtang@gmail.com \
--cc=gengdongjiu@huawei.com \
--cc=huangshaoyu@huawei.com \
--cc=james.morse@arm.com \
--cc=john.garry@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
--cc=wangxiongfeng2@huawei.com \
--cc=will.deacon@arm.com \
--cc=wuquanming@huawei.com \
--cc=zhengqiang10@huawei.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®