From: Rob Herring <robh@kernel.org>
To: "David.Wu" <david.wu@rock-chips.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
davem@davemloft.net, heiko@sntech.de, mark.rutland@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com, olof@lixom.net,
linux@armlinux.org.uk, arnd@arndb.de, peppe.cavallaro@st.com,
alexandre.torgue@st.com, huangtao@rock-chips.com,
hwg@rock-chips.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding
Date: Thu, 17 Aug 2017 10:10:25 -0500 [thread overview]
Message-ID: <20170817151025.sdbusesfq7spy4fm@rob-hp-laptop> (raw)
In-Reply-To: <1bff1793-fe46-f263-fbf5-ef65ffbc5dc9@rock-chips.com>
On Thu, Aug 10, 2017 at 06:57:40PM +0800, David.Wu wrote:
> Hi Andrew, Florian
>
> 在 2017/8/10 8:20, Andrew Lunn 写道:
> > Hi Florian, David.
> >
> > I'm happy with the property name. But i think the text needs more
> > description. We deal with Ethernet switches with integrated PHYs. Yet
> > for us, this property is unneeded.
> >
> > Seeing this property means some bit of software needs to ensure the
> > internal PHY should be used, when given the choice between an internal
> > and external PHY. So i would say something like:
> >
> > If set, indicates that the PHY is integrated into the same
> > physical package as the Ethernet MAC. If needed, muxers should be
> > configured to ensure the (internal) PHY is used. The absence of this
> > property indicates the muxers should be configured so that the
> > external PHY is used.
>
> Are we supposed to replace the words "internal" with "integrated" here?
> So we have three kinds of PHY, they are intenal, external and integrated
> PHYs.
And you can have both a XAUI/serdes phy and the ethernet phy. It should
be clear this is for the latter.
Rob
next prev parent reply other threads:[~2017-08-17 15:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 12:07 [PATCH v4 00/12] Add the internal phy support David Wu
2017-08-09 12:07 ` [PATCH v4 01/12] net: phy: Add rockchip phy driver support David Wu
2017-08-09 12:07 ` [PATCH v4 02/12] multi_v7_defconfig: Make rockchip phy built-in David Wu
2017-08-09 12:07 ` [PATCH v4 03/12] arm64: defconfig: Enable CONFIG_ROCKCHIP_PHY David Wu
2017-08-09 12:07 ` [PATCH v4 04/12] net: stmmac: dwmac-rk: Remove unwanted code for rk3328_set_to_rmii() David Wu
2017-08-09 12:10 ` [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding David Wu
2017-08-09 22:47 ` Florian Fainelli
2017-08-10 0:20 ` Andrew Lunn
2017-08-10 3:58 ` Chen-Yu Tsai
2017-08-10 10:57 ` David.Wu
2017-08-17 15:10 ` Rob Herring [this message]
2017-08-09 12:11 ` [PATCH v4 06/12] net: stmmac: dwmac-rk: Add internal phy support David Wu
2017-08-17 15:10 ` Rob Herring
2017-08-09 12:11 ` [PATCH v4 07/12] net: stmmac: dwmac-rk: Add internal phy support for rk3228 David Wu
2017-08-09 12:11 ` [PATCH v4 08/12] net: stmmac: dwmac-rk: Add internal phy supprot for rk3328 David Wu
2017-08-09 12:12 ` [PATCH v4 09/12] ARM: dts: rk322x: Add support internal phy for gmac David Wu
2017-08-09 12:13 ` [PATCH v4 10/12] ARM: dts: rk3228-evb: Enable the " David Wu
2017-08-09 22:50 ` Florian Fainelli
2017-08-09 12:13 ` [PATCH v4 11/12] ARM64: dts: rockchip: Add gmac2phy node support for rk3328 David Wu
2017-08-09 12:14 ` [PATCH v4 12/12] ARM64: dts: rockchip: Enable gmac2phy for rk3328-evb David Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817151025.sdbusesfq7spy4fm@rob-hp-laptop \
--to=robh@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=hwg@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=peppe.cavallaro@st.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®