From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753216AbdHQQxu (ORCPT ); Thu, 17 Aug 2017 12:53:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36870 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbdHQQxt (ORCPT ); Thu, 17 Aug 2017 12:53:49 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8585981DEB Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Thu, 17 Aug 2017 11:53:47 -0500 From: Josh Poimboeuf To: Meelis Roos , Ingo Molnar Cc: Linux Kernel list Subject: Re: warning: objtool: ...: call without frame pointer save/setup; return with modified stack frame Message-ID: <20170817165347.z4ipxyglu5vvocr2@treble> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 17 Aug 2017 16:53:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 17, 2017 at 04:09:58PM +0300, Meelis Roos wrote: > Today I coticed the following objtool warnings when compiling > 4.13-rc5+git for my Atom 330 PC: > > call without frame pointer save/setup > return with modified stack frame > > Examples (there is a lot more of them in practice): > > arch/x86/kernel/smpboot.o: warning: objtool: arch_update_cpu_topology()+0x29: call without frame pointer save/setup > arch/x86/kernel/smpboot.o: warning: objtool: native_smp_prepare_cpus()+0x530: return with modified stack frame > > mm/vmalloc.o: warning: objtool: __get_vm_area()+0x26: call without frame pointer save/setup > mm/vmalloc.o: warning: objtool: get_vm_area()+0x34: call without frame pointer save/setup > > fs/debugfs/inode.o: warning: objtool: debugfs_initialized()+0x22: call without frame pointer save/setup > fs/debugfs/inode.o: warning: objtool: debugfs_create_file()+0x20: call without frame pointer save/setup > fs/debugfs/inode.o: warning: objtool: debugfs_create_file_unsafe()+0x20: call without frame pointer save/setup > > mm/nobootmem.o: warning: objtool: __alloc_memory_core_early()+0xb2: return with modified stack frame Hi Meelis, Thanks for reporting this issue. This has been already been fixed in the tip tree with the following commit: 5b8de48e82ba ("objtool: Fix '-mtune=atom' decoding support in objtool 2.0") Ingo, would you be willing to put this patch in the 4.13 urgent queue? -- Josh