From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751549AbdHRItP (ORCPT ); Fri, 18 Aug 2017 04:49:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:33137 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750729AbdHRItO (ORCPT ); Fri, 18 Aug 2017 04:49:14 -0400 Date: Fri, 18 Aug 2017 10:49:12 +0200 From: Michal Hocko To: David Rientjes Cc: Andrew Morton , Vlastimil Babka , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks Message-ID: <20170818084912.GA18513@dhcp22.suse.cz> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I am getting mm/compaction.c: In function 'isolate_freepages_block': mm/compaction.c:469:4: error: implicit declaration of function 'pageblock_skip_persistent' [-Werror=implicit-function-declaration] if (pageblock_skip_persistent(page, order)) { ^ mm/compaction.c:470:5: error: implicit declaration of function 'set_pageblock_skip' [-Werror=implicit-function-declaration] set_pageblock_skip(page); when compaction is disabled because isolate_freepages_block is defined also when CONFIG_COMPACTION=n. I haven't checked how to fix this properly yet. -- Michal Hocko SUSE Labs