mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, wangzhou1@hisilicon.com,
	gabriele.paoloni@huawei.com, bhelgaas@google.com,
	songxiaowei@hisilicon.com, wangbinghui@hisilicon.com,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: dwc: make dw_pcie_host_ops const
Date: Sat, 19 Aug 2017 16:25:19 -0500	[thread overview]
Message-ID: <20170819212519.GW28977@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1502264928-30004-1-git-send-email-bhumirks@gmail.com>

On Wed, Aug 09, 2017 at 01:18:48PM +0530, Bhumika Goyal wrote:
> Make these structures const as they are only stored in the ops field of
> a pcie_port structure, which is of type const.
> Done using Coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied to pci/host-hisi and pci/host-kirin for v4.14, thanks!

> ---
>  drivers/pci/dwc/pcie-hisi.c  | 2 +-
>  drivers/pci/dwc/pcie-kirin.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c
> index e51acee..518cd7e 100644
> --- a/drivers/pci/dwc/pcie-hisi.c
> +++ b/drivers/pci/dwc/pcie-hisi.c
> @@ -223,7 +223,7 @@ static int hisi_pcie_link_up(struct dw_pcie *pci)
>  	return hisi_pcie->soc_ops->hisi_pcie_link_up(hisi_pcie);
>  }
>  
> -static struct dw_pcie_host_ops hisi_pcie_host_ops = {
> +static const struct dw_pcie_host_ops hisi_pcie_host_ops = {
>  	.rd_own_conf = hisi_pcie_cfg_read,
>  	.wr_own_conf = hisi_pcie_cfg_write,
>  };
> diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c
> index 33fddb9..a623f96 100644
> --- a/drivers/pci/dwc/pcie-kirin.c
> +++ b/drivers/pci/dwc/pcie-kirin.c
> @@ -441,7 +441,7 @@ static void kirin_pcie_host_init(struct pcie_port *pp)
>  	.link_up = kirin_pcie_link_up,
>  };
>  
> -static struct dw_pcie_host_ops kirin_pcie_host_ops = {
> +static const struct dw_pcie_host_ops kirin_pcie_host_ops = {
>  	.rd_own_conf = kirin_pcie_rd_own_conf,
>  	.wr_own_conf = kirin_pcie_wr_own_conf,
>  	.host_init = kirin_pcie_host_init,
> -- 
> 1.9.1
> 

      reply	other threads:[~2017-08-19 21:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09  7:48 Bhumika Goyal
2017-08-19 21:25 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170819212519.GW28977@bhelgaas-glaptop.roam.corp.google.com \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bhumirks@gmail.com \
    --cc=gabriele.paoloni@huawei.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=songxiaowei@hisilicon.com \
    --cc=wangbinghui@hisilicon.com \
    --cc=wangzhou1@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®