mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	dianders@chromium.org, Michael Davidson <md@google.com>,
	Greg Hackmann <ghackmann@google.com>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Stephen Hines <srhines@google.com>,
	Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
	Bernhard.Rosenkranzer@linaro.org
Subject: Re: [PATCH] x86/build: Use cc-option to validate stack alignment parameter
Date: Mon, 21 Aug 2017 09:53:09 +0200	[thread overview]
Message-ID: <20170821075309.pqppfsxmyy2oqoow@gmail.com> (raw)
In-Reply-To: <20170817182047.176752-1-mka@chromium.org>


* Matthias Kaehlcke <mka@chromium.org> wrote:

> With 8f91869766c0 ("x86/build: Fix stack alignment for CLang") cc-option
> is only used to determine the name of the stack alignment option supported
> by the compiler, but not to verify that the actual parameter <option>=N is
> valid in combination with the other CFLAGS. This causes problems with older
> gcc versions which only support stack alignment on a boundary of 16 bytes
> or higher.
> 
> Also use (__)cc_option to add the stack alignment option to CFLAGS to
> make sure only valid options are added.
> 
> Fixes: 8f91869766c0 ("x86/build: Fix stack alignment for CLang")
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>

I've added the kbuild-bot Reported-by tag to document (and credit) how this bug 
was found.

Thanks,

	Ingo

  reply	other threads:[~2017-08-21  7:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 18:20 Matthias Kaehlcke
2017-08-21  7:53 ` Ingo Molnar [this message]
2017-08-21  9:20 ` [tip:x86/build] " tip-bot for Matthias Kaehlcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170821075309.pqppfsxmyy2oqoow@gmail.com \
    --to=mingo@kernel.org \
    --cc=Bernhard.Rosenkranzer@linaro.org \
    --cc=arnd@arndb.de \
    --cc=dianders@chromium.org \
    --cc=ghackmann@google.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=md@google.com \
    --cc=mingo@redhat.com \
    --cc=mka@chromium.org \
    --cc=ndesaulniers@google.com \
    --cc=srhines@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®