From: Peter Zijlstra <peterz@infradead.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Waiman Long <longman@redhat.com>, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Pan Xinhui <xinhui@linux.vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>,
Andrea Parri <parri.andrea@gmail.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>
Subject: Re: [RESEND PATCH v5] locking/pvqspinlock: Relax cmpxchg's to improve performance on some archs
Date: Mon, 21 Aug 2017 12:55:08 +0200 [thread overview]
Message-ID: <20170821105508.j3p4zv7mdojpyb7e@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170815184034.GD10801@arm.com>
On Tue, Aug 15, 2017 at 07:40:35PM +0100, Will Deacon wrote:
> On Mon, Aug 14, 2017 at 08:47:11PM +0200, Peter Zijlstra wrote:
> > On Mon, Aug 14, 2017 at 01:01:22PM +0100, Will Deacon wrote:
> > > Yeah, that's right, you can't use the STXR status flag to create control
> > > dependencies.
> >
> > Just for my elucidation; you can't use it to create a control dependency
> > on the store, but you can use it to create a control dependency on the
> > corresponding load, right?
>
> Hmm, sort of, but I'd say that the reads are really ordered due to
> read-after-read ordering in that case. Control dependencies to loads
> don't give you order.
No, I meant _from_ the LL load, not _to_ a later load.
> > Now, IIRC, we've defined control dependencies as being LOAD->STORE
> > ordering, so in that respect nothing is lost. But maybe we should
> > explicitly mention that if the LOAD is part of an (otherwise) atomic RmW
> > the STORE is not constrained.
>
> I could well be misreading your suggestion, but it feels like that's too
> weak. You can definitely still have control dependencies off the LL part
> of the LL/SC pair, just not off the SC part.
>
> E.g. this version of LB is forbidden on arm64:
>
> P0:
> if (atomic_inc_return_relaxed(&x) == 2)
> atomic_set(&y, 1);
>
> P1:
> if (atomic_inc_return_relaxed(&y) == 2)
> atomic_set(&x, 1);
>
> Perhaps when you say "the STORE", you mean the store in the atomic RmW,
> rather than the store in the LOAD->STORE control dependency?
Yes. So I was looking to exclude (SC) STORE -> STORE order through
control dependencies.
next prev parent reply other threads:[~2017-08-21 10:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 13:38 Waiman Long
2017-08-09 13:39 ` Waiman Long
2017-08-09 15:06 ` Peter Zijlstra
2017-08-09 15:15 ` Peter Zijlstra
2017-08-10 8:12 ` Boqun Feng
2017-08-10 9:13 ` Peter Zijlstra
2017-08-10 20:49 ` Paul E. McKenney
2017-08-10 11:50 ` Peter Zijlstra
2017-08-10 13:27 ` Waiman Long
2017-08-10 13:58 ` Waiman Long
2017-08-10 16:15 ` Peter Zijlstra
2017-08-10 16:22 ` Waiman Long
2017-08-10 18:18 ` Waiman Long
2017-08-11 9:06 ` Peter Zijlstra
2017-08-14 12:01 ` Will Deacon
2017-08-14 15:01 ` Waiman Long
2017-08-14 16:02 ` Will Deacon
2017-08-14 18:47 ` Peter Zijlstra
2017-08-15 18:40 ` Will Deacon
2017-08-21 10:55 ` Peter Zijlstra [this message]
2017-08-21 18:00 ` Will Deacon
2017-08-21 19:25 ` Peter Zijlstra
2017-08-21 19:42 ` Peter Zijlstra
2017-08-22 15:35 ` Waiman Long
2017-08-22 10:40 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821105508.j3p4zv7mdojpyb7e@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=parri.andrea@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=will.deacon@arm.com \
--cc=xinhui@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®