From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ilya Matveychikov <matvejchikov@gmail.com>
Cc: Baoquan He <bhe@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
ben.hutchings@codethink.co.uk
Subject: Re: [PATCH] lib/cmdline.c: add to the get_options() documentation
Date: Mon, 21 Aug 2017 14:50:37 +0300 [thread overview]
Message-ID: <20170821115036.mg2v7wfl565kksht@mwanda> (raw)
In-Reply-To: <D8F70276-D32C-4977-B66F-C78A60EE8C8A@gmail.com>
On Mon, Aug 21, 2017 at 02:42:52PM +0400, Ilya Matveychikov wrote:
>
> > On Aug 21, 2017, at 1:46 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > I wasn't sure how get_options() worked, so I looked at examples. And by
> > sheer chance the first example I picked the only example which uses it
> > incorrectly... I've added some comments that hopefully help.
> >
>
> See also comments on my patch from Ben Hutchings:
> https://patchwork.kernel.org/patch/9811617/
Ugh... The implementation of get_options() looks gnarly, yes. That
affects the part of my comment which says:
+ * string. It stores the number of numbers as the first element in the
+ * array.
If we are going to keep the current behavior then we should specify that
ints[0] can be higher than "nints - 1". But I feel like the current
behavior is wrong and that get_range() should never return more than n.
regards,
dan carpenter
prev parent reply other threads:[~2017-08-21 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 9:46 Dan Carpenter
2017-08-21 10:42 ` Ilya Matveychikov
2017-08-21 11:50 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821115036.mg2v7wfl565kksht@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=ben.hutchings@codethink.co.uk \
--cc=bhe@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matvejchikov@gmail.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®