From: Ismael Luceno <ismael@iodev.co.uk>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, mchehab@kernel.org,
maintainers@bluecherrydvr.com, andrey.utkin@corp.bluecherry.net,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const
Date: Mon, 21 Aug 2017 09:13:52 -0300 [thread overview]
Message-ID: <20170821121350.GA10157@pirotess.bf.iodev.co.uk> (raw)
In-Reply-To: <1502875025-3224-3-git-send-email-bhumirks@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On 16/Aug/2017 14:47, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pci/solo6x10/solo6x10-g723.c
> index 3ca9470..81be1b8 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-g723.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c
> @@ -319,7 +319,7 @@ static int snd_solo_capture_volume_put(struct snd_kcontrol *kcontrol,
> return 1;
> }
>
> -static struct snd_kcontrol_new snd_solo_capture_volume = {
> +static const struct snd_kcontrol_new snd_solo_capture_volume = {
> .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> .name = "Capture Volume",
> .info = snd_solo_capture_volume_info,
> --
> 1.9.1
>
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-08-21 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 9:17 [PATCH 0/2] [media]: " Bhumika Goyal
2017-08-16 9:17 ` [PATCH 1/2] [media] cx88: " Bhumika Goyal
2017-08-16 9:17 ` [PATCH 2/2] [media] solo6x10: " Bhumika Goyal
2017-08-21 12:13 ` Ismael Luceno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821121350.GA10157@pirotess.bf.iodev.co.uk \
--to=ismael@iodev.co.uk \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®