mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Mike Galbraith <efault@gmx.de>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [rfc patch] sched/topology: fix domain reconstruction memory leakage
Date: Mon, 21 Aug 2017 15:43:11 +0200	[thread overview]
Message-ID: <20170821134311.eoyny4cnn36ichyp@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1503322229.25589.183.camel@gmx.de>

On Mon, Aug 21, 2017 at 03:30:29PM +0200, Mike Galbraith wrote:
> On Mon, 2017-08-21 at 10:16 +0200, Peter Zijlstra wrote:
> > On Sat, Aug 19, 2017 at 08:10:49AM +0200, Mike Galbraith wrote:
> > > Greetings,
> > > 
> > > While beating on cpu hotplug with the shiny new topology fixes
> > > backported, my memory poor 8 socket box fairly quickly leaked itself to
> > > death, 0c0e776a9b0f being the culprit.  With the below applied, box
> > > took a severe beating overnight without a whimper.
> > > 
> > > I'm wondering (ergo rfc) if free_sched_groups() shouldn't be renamed to
> > > put_sched_groups() instead, with overlapping domains taking a group
> > > reference reference as well so they can put both sg/sgc rather than put
> > > one free the other.  Those places that want an explicit free can pass
> > > free to only explicitly free sg (or use two functions).  Minimalist
> > > approach works (minus signs, yay), but could perhaps use some "pretty".
> > > 
> > > sched/topology: fix domain reconstruction memory leakage
> > 
> > I was sitting on this one:
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h=sched/core&id=c63d18dd6ea59eec5cba857835f788943ff9f0d5
> 
> The comment in the patch reads better to me like so:
> 
> @@ -345,15 +346,12 @@ static void free_sched_groups(struct sch
>  static void destroy_sched_domain(struct sched_domain *sd)
>  {
>  	/*
> +	 * A normal sched domain may have multiple group references, an
> +	 * overlapping domain, having private groups, only one.  Iterate,
> +	 * dropping group/capacity references, freeing where none remain.
>  	 */
> 	free_sched_groups(sd->groups, 1);

Made it so, thanks!

      reply	other threads:[~2017-08-21 13:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-19  6:10 Mike Galbraith
2017-08-19  6:22 ` Mike Galbraith
2017-08-21  8:16 ` Peter Zijlstra
2017-08-21 11:45   ` Mike Galbraith
2017-08-21 13:30   ` Mike Galbraith
2017-08-21 13:43     ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170821134311.eoyny4cnn36ichyp@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®