From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754472AbdHUOLq (ORCPT ); Mon, 21 Aug 2017 10:11:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:47579 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754348AbdHUOLl (ORCPT ); Mon, 21 Aug 2017 10:11:41 -0400 Date: Mon, 21 Aug 2017 16:11:39 +0200 From: Jan Kara To: SF Markus Elfring Cc: Al Viro , David Howells , Ingo Molnar , Jan Kara , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH 3/4] isofs: One check less in isofs_read_inode() after error detection Message-ID: <20170821141139.GD31870@quack2.suse.cz> References: <157aa252-0edb-1462-cb6e-44369e8f1645@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <157aa252-0edb-1462-cb6e-44369e8f1645@users.sourceforge.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 19-08-17 09:18:42, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 19 Aug 2017 08:10:40 +0200 > > * Adjust jump targets. > > * Avoid a repeated check for the local variable "bh" after > a memory allocation failure in this function. > > * Delete an initialisation for the local variable "ret" > which became unnecessary with this refactoring. > > Signed-off-by: Markus Elfring I agree that fail: goto out; in the original code is awkward and we can get rid of it. However renaming labels is IMO pointless and > if (bh) > +release_bh: > brelse(bh); > return ret; is just disgusting. Honza -- Jan Kara SUSE Labs, CR