From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754308AbdHUOMz (ORCPT ); Mon, 21 Aug 2017 10:12:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:47712 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754141AbdHUOMw (ORCPT ); Mon, 21 Aug 2017 10:12:52 -0400 Date: Mon, 21 Aug 2017 16:12:50 +0200 From: Jan Kara To: SF Markus Elfring Cc: Al Viro , David Howells , Ingo Molnar , Jan Kara , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH 4/4] isofs: Delete an unnecessary variable initialisation in isofs_read_inode() Message-ID: <20170821141250.GE31870@quack2.suse.cz> References: <0f5ac17e-16bc-7a36-262a-ec7d78de497f@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f5ac17e-16bc-7a36-262a-ec7d78de497f@users.sourceforge.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 19-08-17 09:19:34, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 19 Aug 2017 08:13:46 +0200 > > The local variable "bh" will be set to an appropriate pointer a bit later. > Thus omit the explicit initialisation at the beginning. > > Signed-off-by: Markus Elfring Applied to my tree. Thanks. Honza > --- > fs/isofs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c > index f6d6c2ca8723..3a33b3db712a 100644 > --- a/fs/isofs/inode.c > +++ b/fs/isofs/inode.c > @@ -1298,7 +1298,7 @@ static int isofs_read_inode(struct inode *inode, int relocated) > unsigned long bufsize = ISOFS_BUFFER_SIZE(inode); > unsigned long block; > int high_sierra = sbi->s_high_sierra; > - struct buffer_head *bh = NULL; > + struct buffer_head *bh; > struct iso_directory_record *de; > struct iso_directory_record *tmpde = NULL; > unsigned int de_len; > -- > 2.14.0 > -- Jan Kara SUSE Labs, CR