From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753010AbdHVUtq (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Aug 2017 16:49:46 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:43224 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752573AbdHVUto (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2017 16:49:44 -0400
Date: Tue, 22 Aug 2017 13:49:43 -0700 (PDT)
Message-Id: <20170822.134943.186346483000054388.davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, mail@pheise.de, peter.heise@airbus.com,
        arvid.brodin@alten.se, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net/hsr: Check skb_put_padto() return value
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170821195910.28752-1-f.fainelli@gmail.com>
References: <20170821195910.28752-1-f.fainelli@gmail.com>
X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 22 Aug 2017 13:49:44 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 21 Aug 2017 12:59:10 -0700

> skb_put_padto() will free the sk_buff passed as reference in case of
> errors, but we still need to check its return value and decide what to
> do.
> 
> Detected by CoverityScan, CID#1416688 ("CHECKED_RETURN")
> 
> Fixes: ee1c27977284 ("net/hsr: Added support for HSR v1")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied, thanks.