From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbdHVVUU (ORCPT ); Tue, 22 Aug 2017 17:20:20 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:44070 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752148AbdHVVUP (ORCPT ); Tue, 22 Aug 2017 17:20:15 -0400 Date: Tue, 22 Aug 2017 14:20:14 -0700 (PDT) Message-Id: <20170822.142014.1004582480730502532.davem@davemloft.net> To: andrew@aj.id.au Cc: netdev@vger.kernel.org, benh@kernel.crashing.org, joel@jms.id.au, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org, ryan_chen@aspeedtech.com Subject: Re: [PATCH] net: ftgmac100: Fix oops in probe on failure to find associated PHY From: David Miller In-Reply-To: <20170822063622.21550-1-andrew@aj.id.au> References: <20170822063622.21550-1-andrew@aj.id.au> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 22 Aug 2017 14:20:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Jeffery Date: Tue, 22 Aug 2017 16:06:22 +0930 > netif_napi_del() should be paired with netif_napi_add(), however no > such call takes place in ftgmac100_probe(). This triggers a NULL > pointer dereference if e.g. no PHY is found by the MDIO probe: ... > Signed-off-by: Andrew Jeffery Applied, thanks.