From: Daniel Vetter <daniel@ffwll.ch>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: airlied@linux.ie, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/3] constify drm i2c_device_id
Date: Tue, 22 Aug 2017 08:31:00 +0200 [thread overview]
Message-ID: <20170822062900.vaclssbmt3tiemfl@phenom.ffwll.local> (raw)
In-Reply-To: <1503167300-17334-1-git-send-email-arvind.yadav.cs@gmail.com>
On Sat, Aug 19, 2017 at 11:58:17PM +0530, Arvind Yadav wrote:
> i2c_device_id are not supposed to change at runtime. All functions
> working with i2c_device_id provided by <linux/i2c.h> work with
> const i2c_device_id. So mark the non-const structs as const.
All applied.
btw I think this isn't your first series, and we're trying to keep some of
the trivial mistakes around in drm, as an easy way for newbies to get into
the subsystem with their first patch.
We'd like more regular contributors to tackle some of the more involved
cleanup tasks, which should also be more valuable to the subsystem:
file:///home/daniel/linux/src/Documentation/output/gpu/todo.html#todo
Cheers, Daniel
>
> Arvind Yadav (3):
> [PATCH 1/3] drm: i2c: ch7006: constify i2c_device_id
> [PATCH 2/3] drm: i2c: sil164: constify i2c_device_id
> [PATCH 3/3] drm: i2c: tda998x: constify i2c_device_id
>
> drivers/gpu/drm/i2c/ch7006_drv.c | 2 +-
> drivers/gpu/drm/i2c/sil164_drv.c | 2 +-
> drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2017-08-22 6:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-19 18:28 Arvind Yadav
2017-08-19 18:28 ` [PATCH 1/3] drm: i2c: ch7006: constify i2c_device_id Arvind Yadav
2017-08-19 18:28 ` [PATCH 2/3] drm: i2c: sil164: " Arvind Yadav
2017-08-19 18:28 ` [PATCH 3/3] drm: i2c: tda998x: " Arvind Yadav
2017-08-22 6:31 ` Daniel Vetter [this message]
2017-08-22 9:43 ` [PATCH 0/3] constify drm i2c_device_id Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822062900.vaclssbmt3tiemfl@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=arvind.yadav.cs@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®