From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Takashi Iwai <tiwai@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ALSA: via82xx: Use common error handling code in snd_via82xx_create()
Date: Tue, 22 Aug 2017 22:07:57 +0300 [thread overview]
Message-ID: <20170822190757.76e5edh5t6tgvzpu@mwanda> (raw)
In-Reply-To: <2332472c-61d2-8c21-bf46-5c80745d6380@users.sourceforge.net>
On Tue, Aug 22, 2017 at 07:43:08PM +0200, SF Markus Elfring wrote:
> @@ -1121,30 +1121,27 @@ static int snd_via82xx_create(struct snd_card *card,
>
> if ((err = pci_request_regions(pci, card->driver)) < 0) {
> kfree(chip);
> - pci_disable_device(pci);
> - return err;
> + goto disable_device;
> }
[ snip ]
> @@ -1153,6 +1150,14 @@ static int snd_via82xx_create(struct snd_card *card,
>
> *r_via = chip;
> return 0;
> +
> +disable_device:
> + pci_disable_device(pci);
> + goto exit;
Why is this "goto exit" here? It's leaking now.
> +free_chip:
> + snd_via82xx_free(chip);
> +exit:
> + return err;
> }
regards,
dan carpenter
next prev parent reply other threads:[~2017-08-22 19:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 17:43 SF Markus Elfring
2017-08-22 17:57 ` Takashi Iwai
2017-11-19 6:37 ` SF Markus Elfring
2017-08-22 19:07 ` Dan Carpenter [this message]
2017-08-22 20:05 ` SF Markus Elfring
2017-08-22 20:16 ` Dan Carpenter
2017-08-22 20:19 ` [alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822190757.76e5edh5t6tgvzpu@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®