From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752701AbdHVUM2 (ORCPT ); Tue, 22 Aug 2017 16:12:28 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:43051 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752451AbdHVUM1 (ORCPT ); Tue, 22 Aug 2017 16:12:27 -0400 Date: Tue, 22 Aug 2017 22:12:15 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry Message-ID: <20170822201215.wbpioc7vbse4ajja@flea.home> References: <20170822061742.40869-1-icenowy@aosc.io> <20170822061742.40869-3-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jfeqfidjagrbanq4" Content-Disposition: inline In-Reply-To: <20170822061742.40869-3-icenowy@aosc.io> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jfeqfidjagrbanq4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote: > +®_vcc5v0 { > + gpio =3D <&pio 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */ > + enable-active-high; > +}; Same thing here, you're not using that regulator anywhere. You don't even use any of the regulators in sunxi-common-regulators. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --jfeqfidjagrbanq4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZnJAfAAoJEBx+YmzsjxAgP0EP/0hrfiIbBXpoueVUWWnin36G DbIA/WPGctL9fTGdx5eTFpX583ICTiT6NDes6qYDB/5rS8hlqp1nuNIr5tdi6PIQ 17+9wOi2XlRU86rsee6cVBrRkGcp/xCTxiKyjhdOgGC66C3oD7n0Am1+OBpPfVIM BwHslF5h2htwx33vsK2PgxENJ+UcVQxdhclKhFd3NMajnfG/JrUtm6+zFkl9HbCE U4NcdJe9YReVsPrlr1f/A3H32WOny2kPEYBXHBAh4acIlgreLuDJYVHPyt63rlt6 dBytMvki9DjQ+iIORAZIGZTwtF1a2fRcyPye623ksnTYxlC3tYzdz624W4SeNbOa RMU93phDKc/gdgMI6F0Bc8JVAkv10VGooMC2PuxlskB+aGeHILS4dNyAgk6+Yhgp nC9VCPYqiNLCbDWrDdGgDgnaS+hiRH0iymWItpED20LIA3KBaCFo5ijWVCv/vcCh v7myovUfDiCspFMdelLbA9/PoKrVQK/zYz3OJ/Z0pejaP8OBKiaCNGqAM1MSdDr0 2i2lC7qYST+TzVbaXeLtShWH9E6azH14dNHLuQ/rCEKWDG7iKil+9PUej3hasfIr WeK2KsW3zKxp2Bo5eTCKxq2ET8u+W68QLRnndbeTUfncTxtMS0NUnyy7cDSs3oP+ hecQjUq3cOcl6bvw1Pc2 =xc42 -----END PGP SIGNATURE----- --jfeqfidjagrbanq4--