From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752767AbdHVUSc (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Aug 2017 16:18:32 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:36012 "EHLO
        aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751885AbdHVUSa (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2017 16:18:30 -0400
Date: Tue, 22 Aug 2017 23:16:12 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        Julia Lawall <Julia.Lawall@lip6.fr>, Takashi Iwai <tiwai@suse.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ALSA: via82xx: Use common error handling code in
 snd_via82xx_create()
Message-ID: <20170822201400.lw3bcjlvx4lzlq5d@mwanda>
References: <2332472c-61d2-8c21-bf46-5c80745d6380@users.sourceforge.net>
 <20170822190757.76e5edh5t6tgvzpu@mwanda>
 <d9b9dc7e-9c00-3f1d-f6f8-a2e67110c449@users.sourceforge.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d9b9dc7e-9c00-3f1d-f6f8-a2e67110c449@users.sourceforge.net>
User-Agent: NeoMutt/20170113 (1.7.2)
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 22, 2017 at 10:05:37PM +0200, SF Markus Elfring wrote:
> >> @@ -1121,30 +1121,27 @@ static int snd_via82xx_create(struct snd_card *card,
> >>  
> >>  	if ((err = pci_request_regions(pci, card->driver)) < 0) {
> >>  		kfree(chip);
> >> -		pci_disable_device(pci);
> >> -		return err;
> >> +		goto disable_device;

Ah, you're right.  It's not leaking.  I thought you deleted the
kfree(chip);...

regards,
dan carpenter