From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751248AbdHXFUw (ORCPT ); Thu, 24 Aug 2017 01:20:52 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60470 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbdHXFUv (ORCPT ); Thu, 24 Aug 2017 01:20:51 -0400 Date: Wed, 23 Aug 2017 22:20:50 -0700 (PDT) Message-Id: <20170823.222050.1110892474808104284.davem@davemloft.net> To: colin.king@canonical.com Cc: aviad.krawczyk@huawei.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static From: David Miller In-Reply-To: <20170823095940.27225-1-colin.king@canonical.com> References: <20170823095940.27225-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 23 Aug 2017 22:20:51 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Wed, 23 Aug 2017 10:59:40 +0100 > From: Colin Ian King > > The functions set_ctrl0 and set_ctrl1 are local to the source and do > not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'set_ctrl0' was not declared. Should it be static? > symbol 'set_ctrl1' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Applied.