From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932074AbdHWNnJ (ORCPT ); Wed, 23 Aug 2017 09:43:09 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:51026 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754006AbdHWNnH (ORCPT ); Wed, 23 Aug 2017 09:43:07 -0400 From: Arnd Bergmann To: Rob Clark , Joerg Roedel Cc: Arnd Bergmann , Stanimir Varbanov , iommu@lists.linux-foundation.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iommu: qcom: annotate PM functions as __maybe_unused Date: Wed, 23 Aug 2017 15:42:45 +0200 Message-Id: <20170823134303.1000996-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:OZQ6y2NW7WWwHPLaZ9ncpbudL4NMX2/A01jjPNjpzEX3VIulRe/ /BpIseU2Y4Uqivwipruy6dt6A/wy9Fm7QkkhFo6HOayr+EIUKWYsyodsIISZI1+KWPx4JAx ojurybYYhmpf/4b/yjHawxpyOW1DdlB8jvlZzBnhvfGW2lFAqLPQhST6WFQ8Q/dU9BAwbsG QDHYbItsi8bA0Mz14OiYQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:53qEyDDMS28=:dAxmYCYYRrGz9jeUEm/f7M zwasCNH1IDrTb7shS/1aPNbyf4HAYe7uAyqbh4VXtxdgIFoo+4PpzFum3QvOTJ1xMjmEoThKR zXyuJGM7hL8SpxNr0989zVOpkDiqj0geVeeu2jQkZ+A+tgTZrr74mYt1jdEwCKfRrxhjP7qAh g70p7IjZn1/Ij3Lh9RnT0kgzQYTUuMbspoQY+vaTLpluwU/MQ5sV32a1NFTLdyUjA69zkSsfX HaeG3+tx9DphQIilgR0bbH343Ne5hDQZ9j+UfG0bFCWT4ZzuoPI5b0UhRcg+K9kbEDYVLtSoL 3/nWToZhEfuJ0OaAb/fTl3dnbj+JNPLM/0X7gtjxDMawDH5VZ/D8KxasHehR8SZczzz22yCz4 Hl1m0ujQ3/A9sRMt8fAVa3unpkBKNaYn2WnoCcH9CDFmEWhl88AS7rxoTnyAXc06FwyYharnI UvY+Rteq2vDlcKKWgT1o9dGr+K4wQLoX5zgU68GLQk4zau6lmbQlpwLPTDQKadeneSpgsuaYs JejZTg9NjJjN+I8iml0xFTYfpw+MaySZTHxacoUANEvLbjmownDYb6JCxgrE2DUcuaVNPTUKt LD4WKBFNwLPbJB2J3ROxFjp5OdT69OaM2iynGQwXU0dkJN6ovv19POeMaw0xj8HULHVY2qwKU PQsVXpyEfWiNSdI7BSj9S6wj/YevbjVAJUNvVxHpyuk6zQ1/GzJ2c0UEmk+oCtRHnV9MdsBpf 1hrOGnfq8rAtbumIuk8TT4SU+r5fGvxQhK99Pw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The qcom_iommu_disable_clocks() function is only called from PM code that is hidden in an #ifdef, causing a harmless warning without CONFIG_PM: drivers/iommu/qcom_iommu.c:601:13: error: 'qcom_iommu_disable_clocks' defined but not used [-Werror=unused-function] static void qcom_iommu_disable_clocks(struct qcom_iommu_dev *qcom_iommu) drivers/iommu/qcom_iommu.c:581:12: error: 'qcom_iommu_enable_clocks' defined but not used [-Werror=unused-function] static int qcom_iommu_enable_clocks(struct qcom_iommu_dev *qcom_iommu) Replacing that #ifdef with __maybe_unused annotations lets the compiler drop the functions silently instead. Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu") Signed-off-by: Arnd Bergmann --- drivers/iommu/qcom_iommu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c index 48b62aa52787..c8a587d034b0 100644 --- a/drivers/iommu/qcom_iommu.c +++ b/drivers/iommu/qcom_iommu.c @@ -860,8 +860,7 @@ static int qcom_iommu_device_remove(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM -static int qcom_iommu_resume(struct device *dev) +static int __maybe_unused qcom_iommu_resume(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct qcom_iommu_dev *qcom_iommu = platform_get_drvdata(pdev); @@ -869,7 +868,7 @@ static int qcom_iommu_resume(struct device *dev) return qcom_iommu_enable_clocks(qcom_iommu); } -static int qcom_iommu_suspend(struct device *dev) +static int __maybe_unused qcom_iommu_suspend(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct qcom_iommu_dev *qcom_iommu = platform_get_drvdata(pdev); @@ -878,7 +877,6 @@ static int qcom_iommu_suspend(struct device *dev) return 0; } -#endif static const struct dev_pm_ops qcom_iommu_pm_ops = { SET_RUNTIME_PM_OPS(qcom_iommu_suspend, qcom_iommu_resume, NULL) -- 2.9.0