From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932262AbdHWQBF (ORCPT ); Wed, 23 Aug 2017 12:01:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8531 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754154AbdHWQBE (ORCPT ); Wed, 23 Aug 2017 12:01:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 376C2C056819 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Wed, 23 Aug 2017 11:01:03 -0500 From: Josh Poimboeuf To: Arnd Bergmann Cc: Linux Kernel Mailing List Subject: Re: gcc-8 objtool warnings Message-ID: <20170823160103.hlngl42raetj5ljq@treble> References: <20170823124817.l3ersdabah75ampl@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 23 Aug 2017 16:01:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 23, 2017 at 03:38:02PM +0200, Arnd Bergmann wrote: > On Wed, Aug 23, 2017 at 2:48 PM, Josh Poimboeuf wrote: > > On Wed, Aug 23, 2017 at 02:22:34PM +0200, Arnd Bergmann wrote: > >> ... > >> > >> 0000000000000000 : > >> 0: e8 00 00 00 00 callq 5 > >> 1: R_X86_64_PC32 __sanitizer_cov_trace_pc-0x4 > >> 5: 44 8b 8b 64 ff ff ff mov -0x9c(%rbx),%r9d > >> c: 48 8b 8b 68 ff ff ff mov -0x98(%rbx),%rcx > >> 13: 44 89 e2 mov %r12d,%edx > >> 16: 44 8b 83 60 ff ff ff mov -0xa0(%rbx),%r8d > >> 1d: 4c 89 ee mov %r13,%rsi > >> 20: 48 c7 c7 00 00 00 00 mov $0x0,%rdi > >> 23: R_X86_64_32S .rodata.str1.8+0x28 > >> 27: e8 00 00 00 00 callq 2c <__kstrtab_creds_are_invalid+0x3> > >> 28: R_X86_64_PC32 panic-0x4 > > > > Thanks. Can you send me one of the .o files? > > Attached here now. Ok, looks like I'll need to add support for this new pattern (jumping to a .cold section in .text.unlikely). I'm also about to start work on fixing that other issue you found with GCC's inefficient update of the stack pointer. I really appreciate your finding all these warnings (and getting advance GCC 8 testing). Thanks again! -- Josh