From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932356AbdHWQws (ORCPT ); Wed, 23 Aug 2017 12:52:48 -0400 Received: from mga11.intel.com ([192.55.52.93]:59604 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754154AbdHWQwq (ORCPT ); Wed, 23 Aug 2017 12:52:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,417,1498546800"; d="scan'208";a="143760376" Date: Wed, 23 Aug 2017 09:52:46 -0700 From: "Luck, Tony" To: "Ghannam, Yazen" Cc: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "linux-edac@vger.kernel.org" , Borislav Petkov Subject: Re: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources Message-ID: <20170823165245.52437iccij6sm4ta@intel.com> References: <1502387883-16667-1-git-send-email-Yazen.Ghannam@amd.com> <20170822160305.o4ceuqjnuy4drgxb@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 23, 2017 at 04:37:43PM +0000, Ghannam, Yazen wrote: > > -----Original Message----- > > From: Luck, Tony [mailto:tony.luck@intel.com] > > Maybe you should add the other instruction types that make sense here > > (ACPI_EINJ_READ_REGISTER, ACPI_EINJ_READ_REGISTER_VALUE and > > ACPI_EINJ_WRITE_REGISTER) as a sanity check against the BIOS giving you an > > action in the trigger table that doesn't involve a memory access? > > > > Yes, in that case we can do: > entry->instruction <= ACPI_EINJ_WRITE_REGISTER_VALUE > > That would cover all the memory access instructions and protect against invalid > instructions. > > How does that sound? Perfect. Acked-by: Tony Luck -Tony