From: Peter Zijlstra <peterz@infradead.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Byungchul Park <byungchul.park@lge.com>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
kernel-team@lge.com, Arnaldo Carvalho de Melo <acme@kernel.org>,
Dave Chinner <david@fromorbit.com>, Tejun Heo <tj@kernel.org>,
johannes@sipsolutions.net
Subject: Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING
Date: Wed, 23 Aug 2017 19:47:14 +0200 [thread overview]
Message-ID: <20170823174714.in4mv7uc3rdheygg@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170823163903.GA12973@redhat.com>
On Wed, Aug 23, 2017 at 06:39:03PM +0200, Oleg Nesterov wrote:
> Peter, I am all confused and I am still trying to understand your email.
> In particular, because I no longer understand the lockdep annotations in
> workqueue.c, it turns out I forgot everything...
Yeah, that happens :/
> On 08/22, Peter Zijlstra wrote:
> >
> > I am however slightly puzzled by the need of flush_work() to take Q,
> > what deadlock potential is there?
>
> Do you really mean flush_work()? Or start_flush_work() ?
Same thing, start_flush_work() has exactly one caller: flush_work().
> > It was added by Oleg in commit:
> >
> > a67da70dc095 ("workqueues: lockdep annotations for flush_work()")
>
> No, these annotations were moved later into start_flush, iiuc...
>
> This
>
> lock_map_acquire(&work->lockdep_map);
> lock_map_release(&work->lockdep_map);
>
> was added by another commit 0976dfc1d0cd80a4e9dfaf87bd8744612bde475a
> "workqueue: Catch more locking problems with flush_work()", and at
> first glance it is fine.
Those are fine and are indeed the flush_work() vs work inversion.
The two straight forward annotations are:
flush_work(work) process_one_work(wq, work)
A(work) A(work)
R(work) work->func(work);
R(work)
Which catches:
Task-1: work:
mutex_lock(&A); mutex_lock(&A);
flush_work(work);
And the analogous:
flush_workqueue(wq) process_one_work(wq, work)
A(wq) A(wq)
R(wq) work->func(work);
R(wq)
The thing I puzzled over was flush_work() (really start_flush_work())
doing:
if (pwq->wq->saved_max_active == 1 || pwq->wq->rescuer)
lock_map_acquire(&pwq->wq->lockdep_map);
else
lock_map_acquire_read(&pwq->wq->lockdep_map);
lock_map_release(&pwq->wq->lockdep_map);
Why does flush_work() care about the wq->lockdep_map?
The answer is because, for single-threaded workqueues, doing
flush_work() from a work is a potential deadlock:
workqueue-thread:
work-n:
flush_work(work-n+1);
work-n+1:
Will not be going anywhere fast..
And by taking the wq->lockdep_map from flush_work(), but _only_ when
single-threaded (or rescuer, see other emails), and by doing that, it
forces a recursive lock deadlock message like:
process_one_work(wq, work)
A(wq)
A(work)
work->func(work)
flush_work(work2)
A(work2)
R(work2)
A(wq) <-- recursive lock deadlock
Make sense?
next prev parent reply other threads:[~2017-08-23 17:47 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 8:57 Byungchul Park
2017-08-17 8:57 ` [PATCH v3 2/3] lockdep: Reword title of LOCKDEP_CROSSRELEASE config Byungchul Park
2017-08-17 10:21 ` [tip:locking/core] locking/lockdep: " tip-bot for Byungchul Park
2017-08-17 8:57 ` [PATCH v3 3/3] lockdep: Rename LOCKDEP_COMPLETE config Byungchul Park
2017-08-17 10:22 ` [tip:locking/core] locking/lockdep: Rename CONFIG_LOCKDEP_COMPLETE to CONFIG_LOCKDEP_COMPLETIONS tip-bot for Byungchul Park
2017-08-17 10:21 ` [tip:locking/core] locking/lockdep: Make CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING tip-bot for Byungchul Park
2017-08-17 10:45 ` Ingo Molnar
2017-08-18 5:33 ` Byungchul Park
2017-08-21 15:46 ` [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING Peter Zijlstra
2017-08-22 5:14 ` Byungchul Park
2017-08-22 7:52 ` Peter Zijlstra
2017-08-22 8:51 ` Byungchul Park
2017-08-22 9:21 ` Peter Zijlstra
2017-08-22 9:33 ` Byungchul Park
2017-08-22 10:08 ` Peter Zijlstra
2017-08-22 13:49 ` Peter Zijlstra
2017-08-22 14:46 ` Peter Zijlstra
2017-08-22 15:10 ` Peter Zijlstra
2017-08-22 15:59 ` Oleg Nesterov
2017-08-22 16:35 ` Peter Zijlstra
2017-08-23 16:39 ` Oleg Nesterov
2017-08-23 17:47 ` Peter Zijlstra [this message]
2017-08-24 6:11 ` Byungchul Park
2017-08-24 7:37 ` Byungchul Park
2017-08-24 8:11 ` Byungchul Park
2017-08-25 1:14 ` Byungchul Park
2017-08-29 15:52 ` Oleg Nesterov
2017-08-29 17:07 ` lockdep && recursive-read Oleg Nesterov
2017-08-29 17:30 ` Peter Zijlstra
2017-08-29 17:51 ` [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING Peter Zijlstra
2017-08-23 2:43 ` Byungchul Park
2017-08-23 6:31 ` Byungchul Park
2017-08-23 10:26 ` Peter Zijlstra
2017-08-24 5:07 ` Byungchul Park
2017-08-22 5:46 ` Dave Chinner
2017-08-22 9:06 ` Peter Zijlstra
2017-08-22 9:22 ` Byungchul Park
2017-08-22 9:37 ` Peter Zijlstra
2017-08-22 9:42 ` Peter Zijlstra
2017-08-23 2:12 ` Byungchul Park
2017-08-23 6:03 ` Byungchul Park
2017-08-23 10:20 ` Peter Zijlstra
2017-08-24 2:02 ` Byungchul Park
2017-08-24 7:30 ` Byungchul Park
2017-08-22 21:19 ` Dave Chinner
2017-08-23 2:31 ` Byungchul Park
2017-08-23 6:11 ` Byungchul Park
2017-08-23 10:46 ` Peter Zijlstra
2017-08-24 5:06 ` Byungchul Park
2017-08-23 1:56 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823174714.in4mv7uc3rdheygg@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=byungchul.park@lge.com \
--cc=david@fromorbit.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®