From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751170AbdHXCLM (ORCPT <rfc822;w@1wt.eu>);
        Wed, 23 Aug 2017 22:11:12 -0400
Received: from mail.kernel.org ([198.145.29.99]:60064 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751004AbdHXCLL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 23 Aug 2017 22:11:11 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38D3721A29
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Wed, 23 Aug 2017 22:11:07 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>, Helge Deller <deller@gmx.de>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF
Message-ID: <20170823221107.395bbbf3@gandalf.local.home>
In-Reply-To: <20170824004103.GA3569@jagdpanzerIV.localdomain>
References: <20170810173533.GA11600@ls3530.fritz.box>
        <20170811001521.GA520@jagdpanzerIV.localdomain>
        <47718712-9eb2-8ad7-965e-d0971d07e985@gmx.de>
        <20170815113625.GA2738@pathway.suse.cz>
        <d5fda170-e95b-024e-59ad-650b4db78ba6@gmx.de>
        <20170823144824.GE27895@pathway.suse.cz>
        <20170824004103.GA3569@jagdpanzerIV.localdomain>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 24 Aug 2017 09:41:03 +0900
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:

> On (08/23/17 16:48), Petr Mladek wrote:
> [..]
> > Sometimes people seems unclear when to use the %pS or %pF printk format.
> > For example, see commit 51d96dc2e2dc ("random: fix warning message on ia64
> > and parisc") which fixed such a wrong format string.
> > 
> > The documentation should be more clear about the difference.
> > Also examples might help to avoid some typical mistakes.
> > 
> > Signed-off-by: Helge Deller <deller@gmx.de>
> > [pmladek@suse.com: Restructure the entire section]
> > Signed-off-by: Petr Mladek <pmladek@suse.com>  
> 
> looks great.
> 
> FWIW,
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Also,

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve