From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754456AbdHYB2G (ORCPT ); Thu, 24 Aug 2017 21:28:06 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:59984 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754431AbdHYB2E (ORCPT ); Thu, 24 Aug 2017 21:28:04 -0400 Date: Thu, 24 Aug 2017 18:28:03 -0700 (PDT) Message-Id: <20170824.182803.373650560554315773.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, edumazet@gmail.com, siva.kallam@broadcom.com, prashant@broadcom.com, mchan@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] tg3: Be drop monitor friendly From: David Miller In-Reply-To: <20170825004711.19793-1-f.fainelli@gmail.com> References: <20170825004711.19793-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Aug 2017 18:28:04 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Thu, 24 Aug 2017 17:47:11 -0700 > tg3_tx() does the normal packet TX completion, > tigon3_dma_hwbug_workaround() and tg3_tso_bug() both need to allocate a > new SKB that is suitable to workaround HW bugs, and finally > tg3_free_rings() is doing ring cleanup. Use dev_consume_skb_any() for > these 3 locations to be SKB drop monitor friendly. > > Signed-off-by: Florian Fainelli Applied.