From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754384AbdHYBwC (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 21:52:02 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:60484 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754066AbdHYBwB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 21:52:01 -0400
Date: Thu, 24 Aug 2017 18:52:00 -0700 (PDT)
Message-Id: <20170824.185200.809354587649786034.davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, edumazet@gmail.com, andrew@lunn.ch,
        sebastian.hesselbarth@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: mv643xx_eth: Be drop monitor friendly
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170824.182756.386299059058749250.davem@davemloft.net>
References: <20170824230425.15948-1-f.fainelli@gmail.com>
        <20170824.182756.386299059058749250.davem@davemloft.net>
X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-7
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Aug 2017 18:52:01 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v7P1q755020694

From: David Miller <davem@davemloft.net>
Date: Thu, 24 Aug 2017 18:27:56 -0700 (PDT)

> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Thu, 24 Aug 2017 16:04:25 -0700
> 
>> txq_reclaim() does the normal transmit queue reclamation and
>> rxq_deinit() does the RX ring cleanup, none of these are packet drops,
>> so use dev_consume_skb() for both locations.
>> 
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Applied.

-ENOCOMPILE?

drivers/net/ethernet/marvell/mv643xx_eth.c: In function Ħtxq_reclaim˘:
drivers/net/ethernet/marvell/mv643xx_eth.c:1124:5: error: implicit declaration of function Ħdev_consume_skb˘; did you mean Ħdev_consume_skb_any˘? [-Werror=implicit-function-declaration]
     dev_consume_skb(skb);
     ^~~~~~~~~~~~~~~
     dev_consume_skb_any

Reverted.