From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751701AbdHYEaC (ORCPT ); Fri, 25 Aug 2017 00:30:02 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35778 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbdHYEaA (ORCPT ); Fri, 25 Aug 2017 00:30:00 -0400 Date: Thu, 24 Aug 2017 21:29:59 -0700 (PDT) Message-Id: <20170824.212959.70798260439682691.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, edumazet@gmail.com, jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] e1000e: Be drop monitor friendly From: David Miller In-Reply-To: <20170825035824.26935-1-f.fainelli@gmail.com> References: <20170825035824.26935-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Aug 2017 21:29:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Thu, 24 Aug 2017 20:58:24 -0700 > e1000_put_txbuf() cleans up the successfully transmitted TX packets, > e1000e_tx_hwtstamp_work() also does the successfully completes the > timestamped TX packets, e1000_clean_rx_ring() cleans up the RX ring and > e1000_remove() cleans up the timestampted packets. None of these > functions should be reporting dropped packets, so make them use > dev_consume_skb_any() to be drop monitor friendly. > > Signed-off-by: Florian Fainelli I'll let the Intel folks pick this up.